search

devartis / passbook

Python library to create Apple Passbook (.pkpass) files
http://www.devartis.com/
MIT License
272 stars 108 forks source link

Replace M2Crypto with Cryptography #60

Open shivaRamdeen opened 2 years ago

shivaRamdeen commented 2 years ago

resolves #59

gcartlidge commented 2 years ago

I was having trouble with the existing M2Crypto stuff (plus it's iffy to build if you can't find a pre-compiled one) where the signature wasn't working properly (the pass generated but wouldn't register on phone). Thought what the hell, let's try the cryptography one because it's easy to pip. Pulled this git, fixed my issues! Not exactly sure what it fixed, but my pkpass files work now!

Thanks! 👍

shivaRamdeen commented 2 years ago

I was having trouble with the existing M2Crypto stuff (plus it's iffy to build if you can't find a pre-compiled one) where the signature wasn't working properly (the pass generated but wouldn't register on phone). Thought what the hell, let's try the cryptography one because it's easy to pip. Pulled this git, fixed my issues! Not exactly sure what it fixed, but my pkpass files work now!

Thanks! 👍

Glad it worked for you. Hopefully this PR gets merged soon so everyone can migrate. Cheers.

mbaechtold commented 2 years ago

This is just a first reaction where I'd like to thank you for your pull request. I'll try to have a look at it soon.

NathanQ commented 2 years ago

is test_signing() awaiting M2Crypto replacement? https://github.com/devartis/passbook/pull/60/files#diff-5b9b40c808949b2c3451e00cc35167849bcc2f0e4cb59c821a58c0a01936cb63R132

shivaRamdeen commented 2 years ago

@mbaechtold Any headway with this PR?

sokolx1 commented 1 year ago

resolves #59

Well, maybe i dont understand something. Do i have to change my key generation somehow, in order for this to work?

cryptography does not support the file, that is generated with this command:

openssl pkcs12 -in "Certificates.p12" -nocerts -out private.key

any workarounds?