devaslanphp / project-management

An open source Project management tool based on Laravel and Filament
https://devaslanphp.github.io/project-management
MIT License
721 stars 200 forks source link

Timesheet component missing features #29

Closed mihaisolomon closed 1 year ago

mihaisolomon commented 1 year ago

I think we are missing a few things from this component

If think of anything else please add.

heloufir commented 1 year ago

Hmm I see, do you think of a separated dashboard where the user can view / export data as tables / graphs or something else?

mihaisolomon commented 1 year ago

Yes, something like that, and a widget in the main one with some basic information like reported hours this month.

heloufir commented 1 year ago

Ok I see, so it will like a reporting dashboard giving the user some quick KPI and options to export and view data.

heloufir commented 1 year ago

And I think I should add a date to the logging time so we can log time based on a date.

E.g. we can log 8 hours yesterday and 4 hours today in the same day, now we are based on the system current date.

I think Jira are doing the same.

mihaisolomon commented 1 year ago

Timesheet listing:

image

Menu:

image

I will add the possibility to edit a timesheet entry. Just edit the hours, activity and comment.

heloufir commented 1 year ago

That looks good!

heloufir commented 1 year ago

@mihaisolomon just tested it with a big comment and it looks like below image

I think it would be good to add some limit to the comment column like these:

Tables\Columns\TextColumn::make('comment')
    ->label(__('Comment'))
    ->limit(50)
    ->sortable()
    ->searchable(),
mihaisolomon commented 1 year ago

I'm working on a small widget ( for the timesheet), I will fix this part also. Thanks.

mihaisolomon commented 1 year ago

The first widget looks something like this:

image

heloufir commented 1 year ago

That looks nice, you are using Filament Widgets?

mihaisolomon commented 1 year ago

That looks nice, you are using Filament Widgets?

Yes.

heloufir commented 1 year ago

@mihaisolomon I will hide the Timesheet menu, so I can publish a new release containing the Scrum board without showing the Timesheet menu for now, that's ok for you?

heloufir commented 1 year ago

Just merged the PR #38 When I go to the Timesheet Dashboard, I got this error image

I think the DATE_FORMAT you are using on your SQL Query

mihaisolomon commented 1 year ago

What mysql version you are using?

I had the same issues with mysql 6 a while ago. Now I have 8.

heloufir commented 1 year ago

I am using MariaDB version 10.4.22

mihaisolomon commented 1 year ago

@heloufir Take a look over the timesheet dashboard and see if the error persists. I have the same code running on a server on MariaDb and could not replicate it.

heloufir commented 1 year ago

Yep always the same issue, here is the shared issue: https://flareapp.io/share/Rmr2Qqkm#F108

heloufir commented 1 year ago

@mihaisolomon The issue is the space below 😱

image

You just need to remove the space in there, and the issue is gone.

heloufir commented 1 year ago

I got another issue related to my demo data, I don't really know what is the issue, I think I soft delete an activity somewhere But I think it will be good to check inside the foreach ($collection as $item) if the $item->activity != null before adding the assets, what do you think?

image

heloufir commented 1 year ago

@mihaisolomon Any news on this?

mihaisolomon commented 1 year ago

Yes, I will make an update later this week with a few more things, that contains the fix for it.

mihaisolomon commented 1 year ago

I will close this one because almost all of the components where done. Some of them they don't make sense for this. If you have any other ideas on this please make a new ticket.