search

devaslanphp / project-management

An open source Project management tool based on Laravel and Filament
https://devaslanphp.github.io/project-management
MIT License
721 stars 200 forks source link

Support for Docker #23 #45

Closed JaccoVE closed 1 year ago

JaccoVE commented 1 year ago

Started working on this since it was not there yet, in my case the following additions can successfully build a Docker image.

heloufir commented 1 year ago

@JaccoVE I got this issue, when I run the buildDocker command I am using Docker on Windows with windows virtualization (not wsl), that happened to you?

And also, do you mind putting devaslanphp/helper instead of jaccove/helper so the name of the image stays the same as the repo, because I plan later to put some Github actions to publish the repo directly on Docker Hub

image

JaccoVE commented 1 year ago

I didn’t have this issue, but I’m building it on Linux. Looks like a line-ending error. Will look into it tomorrow and also fix the naming.

JaccoVE commented 1 year ago

I noticed that Git changed the line endings back to CRLF instead of LF for the run.sh. This should be fixed now by the latest commit.

heloufir commented 1 year ago

I made the changes just above, but if needed you can revert or change them.

JaccoVE commented 1 year ago

Didn't see the space error, but sounds good! Good to hear it works :)

I was indeed thinking about how to do the versioning, I agree it is annoying to update this tag number every time, but I do think it would be nice to add. Can't we grab the version number from Git like they do here for example:

https://betterprogramming.pub/how-to-version-your-docker-images-1d5c577ebf54

heloufir commented 1 year ago

@JaccoVE I just released a new version with your dev (this PR), and also a github action .github/workflows/docker-image.yml where I did a trick to dynamically get the release tag and build an image based on this release.

And also you can check the docs section for the docker details: https://devaslanphp.github.io/project-management/#/docker

JaccoVE commented 1 year ago

Looks very good! Let me know when any changes are necessary.