search

devbaji / vue3-google-login

Add Sign In With Google feature to your Vue 3 application
https://github.com/devbaji/vue3-google-login/
MIT License
202 stars 30 forks source link

Not working in top level domains and sub domains #42

Closed gosunoobie closed 6 months ago

gosunoobie commented 1 year ago

i am working on a project the code works fine in my own local server i.e http://localhost:5173 but when i build it and deploy to demo.projectname.com the pop shows and closes automatically after selecting an account. I have made sure that the javascript origin and the redirect uri are all correct but still the issue persists. The error shows

message: "Popup window closed" stack: "Error: Popup window closed\n at new ap (https://accounts.google.com/gsi/client:224:388)\n at iq.B (https://accounts.google.com/gsi/client:274:198)\n at mc (https://accounts.google.com/gsi/client:56:389)\n at .l.dispatchEvent (https://accounts.google.com/gsi/client:55:340)\n at .Ne.G (https://accounts.google.com/gsi/client:125:179)" type: "popup_closed"

can you please look into this?

devbaji commented 1 year ago

@gosunoobie sorry I am not able to replicate this issue. Ensure that your popup window isn't being blocked by popup blockers. Also try disabling all browser extensions.

gosunoobie commented 1 year ago

thanks for the reply, it's a very weird issue but i think that its due to the redirect url mismatch just to make sure if i have a javascript origin set to demo.turbo.com then what should the redirect uri should be in the google api console?

devbaji commented 6 months ago

@gosunoobie Does this issue still exists? Redirect uri is something you provide which will handle the response from google after a successful login, redirect flow is entirely different where instead of popup you will leave from your application and redirected to a google login page, and this only happens when you set ux_mode to 'redirect' (like this). Please re-open if issue still exists