devben-io / docker-portfolio

Dockerized version of Portfolio Performance - An open source tool to calculate the overall performance of an investment portfolio
https://www.portfolio-performance.info/
MIT License
59 stars 12 forks source link

Update Portfolio Performance Repo URL #11

Closed mymazl closed 2 months ago

mymazl commented 7 months ago

Running docker compose after cloning the repo ends up in an error 404 not found.

It seems that the related Portfolio Performance GH repo changed its name from buchen/portfolio to portfolio-performance/portfolio

This is easy fixable by just updating the URL in the DOCKERFILE

mymazl commented 7 months ago

Updated Dockerfile:

# Pull base image.
FROM jlesage/baseimage-gui:alpine-3.12-glibc-v3 AS base

# System config
RUN apk --no-cache add ca-certificates wget curl && update-ca-certificates && \
    add-pkg \
                openjdk11-jre \
                gtk+3.0 \
                dbus-x11 \
                dbus \
                webkit2gtk

FROM base as app

# ENV vars
ARG VERSION
ENV APP_NAME=${APP_NAME:-"Portfolio Performance"}

# Download & install App
## if $VERSION is not set via --build-arg -> fetch latest PP version
RUN     export VERSION=${VERSION:-$(curl --silent "https://api.github.com/repos/portfolio-performance/portfolio/releases/latest" |grep '"tag_name":>
        cd /opt && wget https://github.com/portfolio-performance/portfolio/releases/download/${VERSION}/PortfolioPerformance-${VERSION}-linux.gtk.x>
        tar xvzf PortfolioPerformance-${VERSION}-linux.gtk.x86_64.tar.gz && \
        rm PortfolioPerformance-${VERSION}-linux.gtk.x86_64.tar.gz

# ENV vars
ARG LOCALE
ENV APP_ICON_URL=https://www.portfolio-performance.info/images/logo.png

# Configure App
## if $LOCALE is not set via --build-arg -> use en_US locale
RUN sed -i '1s;^;-configuration\n/opt/portfolio/configuration\n-data\n/opt/portfolio/workspace\n;' /opt/portfolio/PortfolioPerformance.ini && \
        echo "osgi.nl=${LOCALE:-"en_US"}" >> /opt/portfolio/configuration/config.ini && \
        chmod -R 777 /opt/portfolio && \
        install_app_icon.sh "$APP_ICON_URL"

# Copy files to container
ADD rootfs /
mymazl commented 7 months ago

Just update it or feel free to enable me to contribute.

tomlawesome commented 6 months ago

Came here to say exactly this!

gropi75 commented 6 months ago

Thanks for the hint. At the end of line 24 & 25 following is missing: && \

devben-io commented 6 months ago

Hi guys, Thanks for requesting a contribution. I have added you as contributors to the repo. 🚀