line 525: Fix sheet_file assignment to work for schematics outside current directory

devbisme / KiField

Edit/insert/delete part fields in KiCad schematics or libraries using a spreadsheet.

MIT License

70 stars 27 forks source link

line 525: Fix sheet_file assignment to work for schematics outside current directory #45

Closed 4b11b4 closed 5 years ago

4b11b4 commented 6 years ago

I've followed the directions from the "Contributing" file, but:

I don't know how to make a test for this change.
I set up the virtualenv and ran the "python setup.py develop" -- which I believe installs the proper dependencies?
flake8 kifield/kifield.py already fails in various places, none of which are on line 525
python setup.py tests runs 0 tests, not sure why
tox is unable to find python3.4, python3.6 and pypy

I'm happy to work these problems out. I use KiField very often and would be happy to support.

4b11b4 commented 5 years ago

Is this still relevant?

kasbah commented 5 years ago

Is the change still needed for your own use? I would say it's still relevant then. I think it would be ok to skip an automated test for this if you can't think of anything. I don't have merge privileges though.

We should also try and fix up the test suite to make it easier for future contributions.

4b11b4 commented 5 years ago

I still need it, yes.

It is actually someone else's issue, but I had the same problem. I just simply made the pull request based on their fix.

xesscorp commented 5 years ago

Thanks for the fix!

4b11b4 commented 5 years ago

Thanks for all of the hours you've saved me!