search

devbisme / KiPart

Python package for generating multi-unit schematic symbols for KiCad from a CSV file.
MIT License
170 stars 46 forks source link

Added a flag to set box fill #47

Closed dvdfreitag closed 4 years ago

dvdfreitag commented 4 years ago

I wanted to be able to set the fill style from the cli, so I added an option, --fill, to accomplish this. Instead of a fixed global, the argument parser now passes the fill option into draw_symbol which generates the symbol boxes using the specified fill style.

I opted to use the existing naming convention as opposed to a more complex eg --fill fg or --fill foreground to map to fg_fill etc. I figure the names are still suitably self-explanatory and easy enough to type out.

The usage documentation has been updated to include the new optional flag, as well as an explanation of the available configurations in human-readable format. I did not include anything in the readme since this is a relatively trivial feature.

xesscorp commented 4 years ago

Thanks for your improvement! I made a few minor changes, ran some tests, added your name to the list of contributors, and released it as 0.1.41 on PyPi.