devbisme / skidl

SKiDL is a module that extends Python with the ability to design electronic circuits.
https://devbisme.github.io/skidl/
MIT License
1.04k stars 118 forks source link

fix: make is_url handle windows paths. #189

Closed 2e0byo closed 1 year ago

2e0byo commented 1 year ago

current implementation thinks c:\ has a scheme.

2e0byo commented 1 year ago

See https://github.com/devbisme/skidl/discussions/183

devbisme commented 1 year ago

I merged this into the development branch. I had to remove the type-checking from is_url in order to pass tests for Python 2.7.

Thanks!

2e0byo commented 1 year ago

Oh! I assumed 2.7 in the tests was just leftover. I'm impressed you're still supporting python 2!