search

devbisme / skidl

SKiDL is a module that extends Python with the ability to design electronic circuits.
https://devbisme.github.io/skidl/
MIT License
1.04k stars 118 forks source link

Fix of AC sources, added skidl pyspice comparison notebook #98

Closed GProtoZeroW closed 3 years ago

GProtoZeroW commented 3 years ago

Fixed issue with ac sinusoid sources not getting value from skidl -> pyspice being set for ac_magnitue to enable correct .ac ngspice simulations; see: https://skidl.discourse.group/t/pyspice-translation-issue/44 for raising of the issue.

Also added notebook do document and compare netlist generation from skidl and pyspice. see https://github.com/GProtoZeroW/skidl/blob/master/skidl/libs/skidl_2_pyspice_check.ipynb

in the pull request, still working on going through all the elements in pyspice BasicElement and pyspice HighLevelElement

xesscorp commented 3 years ago

I merged this into the development branch. It will go out in the next release.

GProtoZeroW commented 3 years ago

Sweet

On Mon, Nov 16, 2020, 2:21 PM xesscorp notifications@github.com wrote:

I merged this into the development branch. It will go out in the next release.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/xesscorp/skidl/pull/98#issuecomment-728336284, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3Q7ORI4CORDC5IEIJFTRTSQGJUFANCNFSM4TVA2F3A .