devblackops / NetScaler

PowerShell module for interacting with Citrix NetScaler via the Nitro API
Apache License 2.0
69 stars 32 forks source link

Typo in Add-NSLBVirtualServerBinding and refactoring of Get-NSSystemFile #40

Closed dbroeglin closed 8 years ago

dbroeglin commented 8 years ago

Typo in Add-NSLBVirtualServerBinding and refactoring of Get-NSSystemFile

Refactoring

These additions and changes were required in my own production environment for specific things I needed to do. They are also the basis of upcoming changes.

How Has This Been Tested?

Tested by using the new and changed functions. All appears to be working as expected.

Types of changes

Remark: tests are passing except for :

    [-] changelog and manifest versions are the same 13ms
    Expected: {1.3.0}
    But was:  {1.4.0}
    64:             $script:changelogVersion -as [Version] | Should be ( $script:manifest.Version -as [Version] )
    at <ScriptBlock>, C:\vagrant\Tests\meta\Manifest.Tests.ps1: line 64

but the same test fails on the "dev" branch.

devblackops commented 8 years ago

Thanks Dominique. I removed the version in the unreleased section of the changelog to fix the Pester test for changelog/module version match.