devblackops / NetScaler

PowerShell module for interacting with Citrix NetScaler via the Nitro API
Apache License 2.0
69 stars 32 forks source link

Get-NSSystemFile's FileLocation parameter should be mandatory even when providing a Name #71

Closed dbroeglin closed 7 years ago

dbroeglin commented 7 years ago

Expected Behavior

The filelocation argument is mandatory when calling method GET for nssystemfile:

  1. The Get-NSSystemFile function should reflect this.
  2. The argument being mandatory even when requesting a named resource, the function should allow for passing it through.

Current Behavior

  1. Get-NSSystemFile is allowed but fails when calling NS.
  2. "filename" | Get-NSSystemFile -FileLocation /tmp fails because the filelocation argument is not passed through to NS.

Possible Solution

  1. Make -FileLocation mandatory
  2. Change _InvokeNSRestApiGet to allow for argument passing even when looking up resources.

Steps to Reproduce (for bugs)

  1. Get-NSSystemFile fails with error 509
  2. "filename" | Get-NSSystemFile -FileLocation /tmp fails with error 509

Your Environment