devblackops / building-powershell-modules-feedback

Feedback on the PowerShell Module Development book
6 stars 1 forks source link

Grammatical error: #8

Closed jbirley closed 4 years ago

jbirley commented 4 years ago

Chapter 7

Section: 7.1.2 Candidates for private functions

States

When deciding on if a PowerShell command should be public or private, we should answer the following questions:

Recommendation

When deciding if a PowerShell command should be public or private, we should answer the following questions:

Section: 7.1.2 Candidates for private functions

States

When looking at the AcmeEmployee, we can probably think of many functions that are good candidates to be private to the module.

Recommendation

When looking at the AcmeEmployee module, we can probably think of many functions that are good candidates to be private to the module.

Section: 7.1.3 Controlling the visibility of variables and aliases

States

15 # Define aliases
16 $aliases  = @()
17 $aliases += New-Alias -Name gae -Value Get-AcmeEmployee
18 $aliases += New-Alias -Name sae -Value Set-AcmeEmployee

Recommendation

15 # Define aliases
16 $aliases  = @()
17 $aliases += New-Alias -Name gae -Value Get-AcmeEmployee -PassThru
18 $aliases += New-Alias -Name sae -Value Set-AcmeEmployee -PassThru

Section: 7.2 Summary (Key points callout)

States

Recommendation

devblackops commented 4 years ago

Thanks! Corrected.