devbolcom / bolcom-openapi-csharplib-client

C# library for bol.com Open API v4
0 stars 6 forks source link

ProductOffersRequest and ProductsRequest only return 1 offer instead of all offers. #1

Open mitchell-amasia opened 9 years ago

mitchell-amasia commented 9 years ago

I have tested this with this product --> http://www.bol.com/nl/p/9200000035330615/9200000035330615 At the time of writing, there were 3 offers on the website. But I only get 1 offer thru the API when using this client.

derkmdt commented 9 years ago

Hi Mitchell-amasia,

Are you aware that by default one offer is returned. See the docs on https://developers.bol.com/documentatie/open-api/handleiding/api-requests/catalog/get-catalogv4products/ . If you specifiy &offers=all , you will get all offers.

Sorry for the late reply :)

mitchell-amasia commented 9 years ago

Hi @derkmdt ,

Yes, I was aware of that. That was the whole problem. I was specifying "&offers=all" but I only get 1 offer returned.

The problem was that there was a typing error in the client SDK. ("offer" instead of "offers") So it always defaulted to return only 1 offer no matter what I specify.

I fixed the issue and created a pull request and it was accepted. So I think this issue should be closed by now :)

Greets,

Mitchell