search

devboy / buildr_as3

“build like you code” – now supporting ActionScript 3 & Flex
devboy.org
MIT License
34 stars 5 forks source link

Would be nice to have copylocale support (and other bins too) #30

Open squeedee opened 13 years ago

squeedee commented 13 years ago

We use copylocale to make sure we can compile with a different locale set up. So it's imperative that the sdk has copylocale run for each locale we use.

I've committed an initial solution for some review: https://github.com/devboy/buildr_as3/tree/feature/copylocaleSupport

devboy commented 13 years ago

You can merge this into master if you're confident it works, as I (shame on me) haven't setup any UnitTests yet.

squeedee commented 13 years ago

no not confident. It needs invoke to ensure the sdk is downloaded. It also has java settings collisions that need testing. I'll do those first, at the least.

devboy commented 13 years ago

I can have a look at the invoke method! There is also an ActAsArtifact mixin in buildr which every toolkit should make use of!

squeedee commented 13 years ago

I've merged down what i have, It works at least for me, and it's orthogonal to everything else (should not cause any regressions).

ActsAsArtifact sounds interesting... you going to look at refactoring it or should I? And get on skype dagnabbit :P

devboy commented 13 years ago

Is this the intended behavior of (copy-) locales? http://www.herrodius.com/blog/123

squeedee commented 13 years ago

That's the point of copy locale. it's not the point of my other locale ticket though. It "could" be integrated but I wouldn't rush to combine the two just yet.

devboy commented 12 years ago

Haven't tested this yet? Can we close this issue?