search

devbridge / BetterCMS

A publishing focused and developer friendly .NET Open Source CMS.
GNU Lesser General Public License v3.0
375 stars 151 forks source link

Master page: Maybe it would be worth to add confirmation trying to delete content with dynamic region? #785

Closed daivabrazukaite closed 10 years ago

daivabrazukaite commented 11 years ago

Currently next situation is available: there is master page with contentA which has dynamic region. Page1 is created according this master page, some content is added into contentA and page with all it content is published. Open again master page and delete contentA: content will be deleted without any info, that some other page will be impacted.

Audrunas commented 11 years ago

The same logic should work when trying to delete not content, but a region inside a content. User should confirm, that he knows, that deleting a content would affect another pages.

Audrunas commented 11 years ago

Created fix for HTML content and BlogPost content: when trying to remove a content, which is used in child pages, user must confirm the deletion. Restore is still possible, by restoring old version of the updated content.

Audrunas commented 11 years ago

Also, when deleting a content with dynamic regions, user is asked to confirm the deletion. Fix will be available from 1.4.0-beta8+

daivabrazukaite commented 11 years ago

I suppose check is also needed if older version not containing some region which already has content in child page is chosen to restore from history

ghost commented 11 years ago

Fixed in c48b9ecfa770d326579411ade3ba7ae35aeace5e

ghost commented 11 years ago

Update available from 1.4.0-rc3+