devbridge / Performance

Client side performance tool
MIT License
543 stars 24 forks source link

Fixed results folder not being changed by options #38

Closed danbovey closed 8 years ago

danbovey commented 8 years ago

Hi, great plugin! But I was experiencing the same issue as #36 and straight away looking at the code I could see that resultsFolder wasn't being updated.

I'm not sure why it was coded with a bunch of variables at the top. Everything should go into the settings object, and then that can be your one source of truth. So potentially look into why you have siteURL, sitePages and sitePagesUrls variables - even though these are not causing you issues now.

With these changes, I was able to run gulp perf-tool and get it to write to my public directory!