adjustWorkers is not notified on exit, thus potential resource leak

devchat-ai / gopool

GoPool is a high-performance, feature-rich, and easy-to-use worker pool library for Golang.

MIT License

187 stars 26 forks source link

adjustWorkers is not notified on exit, thus potential resource leak #1

Closed oliver258 closed 1 year ago

oliver258 commented 1 year ago

https://github.com/devchat-ai/gopool/blob/d1a07e8aa342f8df3e82d661198723bcc052dee5/gopool.go#L112C2-L112C2

daniel-hutao commented 1 year ago

Thank you for your feedback. I have merged your PR, and I have also added a commit for some optimizations. Please review my changes and see if they are reasonable. Thanks again, you are the first contributor to the current project (excluding myself).

https://github.com/devchat-ai/gopool/commit/2ea0ed3d821afda9732c6e14d7aa900dbabb90f6

daniel-hutao commented 1 year ago

I wrote a blog about this issue/pr: 《让 GPT-4 来 review 开源社区贡献者的 PR》