Compatibility to Angular universal - Githubissues

devconcept / ng-shopping-cart

🛒 An Angular component library to create shopping carts

https://devconcept.github.io/ng-shopping-cart/

MIT License

45 stars 53 forks source link

Compatibility to Angular universal #10

Open abelpuentes opened 4 years ago

abelpuentes commented 4 years ago

PR Checklist

Verify that you did the following:

[x] Opened an issue to track and discuss the problem you are trying to solve.
[x] Submitted the changes using a new branch in your fork of this repo.
[x] Added test for the changes and checked that code coverage didn't diminished if possible.
[x] Docs were updated using jsdoc style comments when necessary.

Describe what you did

Used variable window based on PLATFORM_ID, to avoid issues in projects using Angular Universal.

Is this a breaking change?

[ ] Yes
[x] No

Other information

abelpuentes commented 3 years ago

@devconcept could you please check this pull request?

abelpuentes commented 3 years ago

@devconcept do you have any feedback?