search

devcontainers-community / publish-feature

💻 Publish a single devcontainer feature
MIT License
0 stars 1 forks source link

Make this Action obsolete! #4

Open jcbhmr opened 1 year ago

jcbhmr commented 1 year ago

ideally this action should become obsolete because this should be either in the official devcontainer CLI or under @devcontainers official org.

i think https://github.com/devcontainers/action/issues/134 is related to this

0xE1E10 commented 9 months ago

That seems to exactly be what devcontainers-contrib is doing. https://github.com/devcontainers-contrib/features/blob/main/.github/workflows/release.yaml

Also, there's a bug in this repo. We're generating tarballs with hardlink to itself due to the same file being referenced indirectly thru parent dir. https://github.com/devcontainers/cli/issues/699#issuecomment-1857139272 devcontainer CLI and vscode chokes on it. It maybe easier to just retire this and make it Microsoft's problem instead of trying to fix it.

0xE1E10 commented 9 months ago

If you don't have any objections, I'll try to make the switch in features-llvm to fix https://github.com/devcontainers-community/features-llvm/issues/4 The feature is currently broken and un-usable. So there's no risk.

Probably not worth the time debugging why this action is trigger the bug in dev container CLI for that specific feature. The bug in dev container comes from their upstream in a tar node package so it will probably take a while to get fixed.

mering commented 1 month ago

Thanks @0xE1E10 for pointing me to a workaround. We have the same issue with features-bazel. I also worked around like you did in features-llvm in devcontainers-community/features-bazel#13.