search

devcontainers-contrib / features

🐳 Extra add-in features for Devcontainers and GitHub Codespaces
MIT License
215 stars 113 forks source link

Question regarding feature contribution #319

Open sdrzazga opened 1 year ago

sdrzazga commented 1 year ago

Hi.

I frequently use the following tools and was wondering, if I could contribute them perhaps as features?

Many thanks for considering my request.

danielbraun89 commented 1 year ago

Thanks @sdrzazga for bringing up these tools, I took it as an opportunity to test the flexibility of our new feature-definition approach 😄

Jfrog CLI is easy enough, it has multiple straight forward options so it was easy to include several of them (curl based, npm based, and homebrew based)

mongodb atlas cli - It has an easy tar.gz installation process - but not one that is easy to automate (hard to resolve what is the latest version ,etc). I have found an official brew repo (homebrew works on linux too) so I have added it, but its non-optimal (slower installation)

mongo-tools is more complicated -same simple but hard-to-automate tar.gz process, and I would have used the asdf installation - but it appears deprecated. will revisit in the future

pull request for the above is: #323

I will keep this issue open until all features are appropriately implemented (by me or someone else)

sdrzazga commented 1 year ago

Hello @danielbraun89 .

Thank you very much for the swift response and implementation of JFrog CLI as a feature. I'm a little busy these days, but I'll definitely try to implement MongoDB Atlas CLI & MongoDB Database Tools.