devcontainers-contrib / features

🐳 Extra add-in features for Devcontainers and GitHub Codespaces
MIT License
224 stars 116 forks source link

tailscale won't install on ARM Linux devices #425

Closed jamesez closed 1 year ago

jamesez commented 1 year ago

Feature id and version

ghcr.io/devcontainers-contrib/features/tailscale:1.0.9

Devcontainer base Image

Any

What happened?

The Tailscale feature depends on curl-apt-get:1.0.7 but: curl-apt-get pulls down featmake, which then tries to download and call an x86 binary, oras.

The fix may be as easy as changing the dependency to curl-apt-get:1.0.15.

Relevant log output

#0 0.230 ===========================================================================
#0 0.230 Feature       : Tailscale (via tailscale.com)
#0 0.230 Description   : Tailscale is a VPN service that makes the devices and applications you own accessible anywhere in the world, securely and effortlessly.
#0 0.230 Id            : ghcr.io/devcontainers-contrib/features/tailscale
#0 0.230 Version       : 1.0.9
#0 0.230 Documentation : http://github.com/devcontainers-contrib/features/tree/main/src/tailscale
#0 0.230 Options       :
#0 0.230 
#0 0.230 ===========================================================================
#0 0.233 bash: cannot set terminal process group (1): Inappropriate ioctl for device
#0 0.233 bash: no job control in this shell
#0 1.932 nanolayer
#0 4.192 cd /tmp/tmpqoeqf087 && chmod +x -R . && _REMOTE_USER="vscode" _REMOTE_USER_HOME="/home/vscode" NANOLAYER_VERBOSE="" NANOLAYER_FORCE_CLI_INSTALLATION="" NANOLAYER_PROPAGATE_CLI_LOCATION="1" NANOLAYER_CLI_LOCATION="/tmp/nanolayer-BMUzaCSzN3/nanolayer" bash  -i  +H ./install.sh
#0 4.192 featmake: OK

#0 4.239 resolved remote username: vscode , with home dir: /home/vscode

#0 4.239 oras not found, installing...

#0 4.246   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current

#0 4.247                                  Dload  Upload   Total   Spent    Left  Speed

#0 4.248 
  0     0    0     0   
[2023-05-17T01:44:15.263Z]  0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

#0 4.575 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 3298k  100 3298k    0     0  3640k      0 --:--:-- --:--:-- --:--:-- 5716k

#0 5.237 /usr/local/bin/featmake: line 146: /usr/local/bin/oras: cannot execute binary file: Exec format error
danielbraun89 commented 1 year ago

@jamesez thanks for reporting this! Indeed It looks like the fix should be just upgrading to latest curl-apt-get feature dependency I have created a new version of tailscale feature with the updated version,
Unfortunately, I dont have an ARM environment to test it on, so I will not close this issue yet, at least until someone can verify the latest version ghcr.io/devcontainers-contrib/features/tailscale:1.0.10 solved it

jamesez commented 1 year ago

On my AWS ARM VM, I used this trivial devcontainer.json:

{
    "name": "Tailscale Test",
    "image": "mcr.microsoft.com/devcontainers/base:debian",

    // Features to add to the dev container. More info: https://containers.dev/features.
    "features": {
        "ghcr.io/devcontainers-contrib/features/tailscale:1.0.10": {}
    }
}

and it built successfully, Tailscale is present (v1.40.1).

danielbraun89 commented 1 year ago

Terrific! closing