search

devcontainers-contrib / features

🐳 Extra add-in features for Devcontainers and GitHub Codespaces
MIT License
224 stars 116 forks source link

[Feature Request]: Can you add support for txs support for Typescript #461

Closed mdabir1203 closed 1 year ago

mdabir1203 commented 1 year ago

Requested Feature

It could be done in similar way like below. Or if you have any guidelines we can do this

// devcontainer.json { "name": "TypeScript Devcontainer", "image": "your-custom-devcontainer-image", "extensions": [ "dbaeumer.vscode-eslint" ], "features": { "ghcr.io/devcontainers-contrib/features/tsx:1": { "version": "latest", "clientOnly": "true" } } }

In this configuration, the ghcr.io/devcontainers-contrib/features/tsx:1 feature is specified to install TypeScript. By setting "clientOnly": "true", only the TypeScript client and related tools will be installed, without the full TypeScript server.

danielbraun89 commented 1 year ago

@mdabir1203 thanks for the suggestion! added both tsx and ts-node features (ghcr.io/devcontainers-contrib/features/tsx:1 and ghcr.io/devcontainers-contrib/features/ts-node:1

I hope I unserstood the client-only flag correctly, so currently I opted to is not installing typescript by default and if wanted, it needs to be manually installed (or by using its designated feature)

mdabir1203 commented 1 year ago

Thanks a ton :)