search

devcontainers-contrib / features

🐳 Extra add-in features for Devcontainers and GitHub Codespaces
MIT License
215 stars 113 forks source link

[Bug]: 'neovim-apt-get' does not build on debian base image #500

Closed deathInTheAfternoon closed 10 months ago

deathInTheAfternoon commented 11 months ago

Feature id and version

ghcr.io/devcontainers-contrib/features/neovim-apt-get:1

Devcontainer base Image

mcr.microsoft.com/devcontainers/base:debian

What happened?

On WSL2, when building 'neovim-apt-get' using mcr.microsoft.com/devcontainers/base:ubuntu the build is successful.

When building using 'mcr.microsoft.com/devcontainers/base:debian' or 'mcr.microsoft.com/devcontainers/typescript-node:1-20-bullseye' the build fails with errors.

Relevant log output

# Debian image...
nanolayer.utils.invoker.Invoker.InvokerException: The command 'add-apt-repository -y ppa:neovim-ppa/stable' failed. error: Return Code: 1. see logs for details.
...
nanolayer.utils.invoker.Invoker.InvokerException: The command 'add-apt-repository -y --remove ppa:neovim-ppa/stable' failed. error: Return Code: 1. see logs for details.

# Typescript-node base image...
nanolayer.utils.invoker.Invoker.InvokerException: The command 'cd /tmp/tmptjk8taga && chmod +x -R . && _REMOTE_USER="node" _REMOTE_USER_HOME="/home/node" PACKAGES="neovim" PPAS="ppa:neovim-ppa/stable" FORCE_PPAS_ON_NON_UBUNTU="true" CLEAN_PPAS="true" PRESERVE_APT_LIST="true" NANOLAYER_VERBOSE="" NANOLAYER_FORCE_CLI_INSTALLATION="" NANOLAYER_PROPAGATE_CLI_LOCATION="1" NANOLAYER_CLI_LOCATION="/tmp/nanolayer-QveaJr6MGo/nanolayer" bash  -i  +H ./install.sh' failed. error: Return Code: 1. see logs for details.

nanolayer.utils.invoker.Invoker.InvokerException: The command 'apt-get update -y' failed. error: Return Code: 100. see logs for details.

ERROR: Feature "Neovim (via apt-get)" (ghcr.io/devcontainers-contrib/features/neovim-apt-get) failed to install! Look at the documentation at http://github.com/devcontainers-contrib/features/tree/main/src/neovim-apt-get for help troubleshooting this error.
danielbraun89 commented 10 months ago

@deathInTheAfternoon thanks for reporting! the bug has been tracked to a failure to add ppas on debian. in latest version of the feature a new version of nanolayer is being used, which ignore ppas on debian (unless forced by a dedicated flag)

please try ghcr.io/devcontainers-contrib/features/neovim-apt-get:1.0.18