search

devcontainers-contrib / features

🐳 Extra add-in features for Devcontainers and GitHub Codespaces
MIT License
214 stars 111 forks source link

[Feature Request]: install several asdf packages with asdf-package feature #527

Open cgrothaus opened 9 months ago

cgrothaus commented 9 months ago

Requested Feature

It would be great if the asdf-package Devcontainer Feature supported installing several asdf packages.

Currently it only supports installing one asdf package, and Devcontainer Features cannot occur more than once in devcontainer.json.

cgrothaus commented 9 months ago

Maybe this could be an intermediate step towards #521.

danielbraun89 commented 9 months ago

Seems like a great enhancement, the only issue is how to handle the pluginRepo argument for the feature. Do we allow multiple comma separated repos, corresponding to the same order of the packages names? What about more specific arguments that may be added in the future?

My intuition leads me towards breaking it down to 3 features (in order to increase future-proofness )

asdf feature that would install asdf installer itself asdf-package feature that would install a single asdf package and allow all the asdf flags (that make sense) as arguments multi-asdf-packages feature, that will accept comma separated packages and will install them as is, with the caveat that for more installation arguments you should use the more specific asdf-package feature.

This can also serve as a standard convention for more installer based features (such as node and pipx packages)

@cgrothaus thoughts?

cgrothaus commented 9 months ago

Your proposed split between asdf and asdf-package sounds reasonable to me 👍 .

Regarding multi-asdf-packages: maybe the need is not so great anymore. Thanks to your efforts, there are so many tailor-made devcontainer features that install a specific language or runtime via asdf (with ruby-asdf and node-asdf being the latest additions) that I now have everything I need, but if you find the time to add such a feature, it still adds value IMHO.

a-b commented 4 months ago

Hello, I was wondering if there has been any progress made regarding this matter?