devcontainers-contrib / features

🐳 Extra add-in features for Devcontainers and GitHub Codespaces
MIT License
240 stars 126 forks source link

Allow api-ops arm version install #533

Closed ross-p-smith closed 1 year ago

ross-p-smith commented 1 year ago
danielbraun89 commented 1 year ago

@ross-p-smith thanks for the contribution regarding the arm asset selection: Im trying as a design decision to minimize logic in the bash shell scripts. The selection of the correct asset should optimally be resolved as part of the nanolayer utility. I have fixed the ARM selection regex in the nanolayer version v0.5.4 (along side with a platform ignore flag, because of the misleading .exe. suffix)

please try feature ghcr.io/devcontainers-contrib/features/azure-apiops:1.0.1 for the fixed version, and ill close this PR as not required

I have used QEMU to test the ARM selection (don't have a mac) it seems to be working for now, but if you still encounter problems please open a bug issue and ill handle it 😄