search

devcontainers / action

GitHub Action to build & publish your own dev container assets
https://containers.dev
MIT License
60 stars 17 forks source link

Upgrade to Node20 #203

Open lure8225 opened 12 months ago

lure8225 commented 12 months ago

Is there any timeline for an update to Node 20 as Node 16 is out of support since September 11th? https://nodejs.org/en/blog/announcements/nodejs16-eol

Thanks

eljog commented 12 months ago

Thank you for opening this issue.

@joshspicer do we have any known reasons to keep the image pinned to Node 16?

joshspicer commented 12 months ago

No known blockers :)

eljog commented 12 months ago

@lure8225 thanks again for opening this issue. I am afraid we have capacity to tackle it in the short term. Would you be willing to contribute a PR (from a fork) to upgrade Node? We are more than happy to support with the review on your contribution.

lure8225 commented 12 months ago

Thanks for the quick reactions, sadly it might take some time until I can properly contribute (company politics/processes). If there are no known issues the change would be just to change the 16 to a 20 here: https://github.com/devcontainers/action/blob/5002ae5962899e0fd372f7affde2c3e176372682/action.yml#L78

However there might be some things as you build the actual action from typescript that I'm not aware of as I have not looked into the build process of the action yet.

And most likely tag/release a new version (which I can't do anyway).

tremblaysimon commented 9 months ago

Should be close since it has been resolved by #207

jpawlowski commented 4 months ago

In the meantime, GitHub moved on already:

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/