search

devcontainers / ci

A GitHub Action and Azure DevOps Task designed to simplify using Dev Containers (https://containers.dev) in CI/CD systems.
MIT License
303 stars 46 forks source link

gh: refactor community files #222

Closed SauravMaheshkar closed 1 year ago

SauravMaheshkar commented 1 year ago

This PR aims to move the CODEOWNERS and CONTRIBUTING.md file from the root of the directory to the .github/ directory. Github looks for a contribution guideline file in the following order: .github dir > project root > docs dir (source). Moving the file to the .github/ dir leads to a minimal project structure without any functional change.

stuartleeks commented 1 year ago

I'm happy to move CODEOWNERS but my personal feeling is that having CONTRIBUTING.md in the root aids discoverability.

@chrmarti - what are your thoughts?

SauravMaheshkar commented 1 year ago

of course, I'll reiterate after feedback.

chrmarti commented 1 year ago

I'm happy to move CODEOWNERS but my personal feeling is that having CONTRIBUTING.md in the root aids discoverability.

Makes sense! 👍

SauravMaheshkar commented 1 year ago

I'm happy to move CODEOWNERS but my personal feeling is that having CONTRIBUTING.md in the root aids discoverability.

Makes sense! 👍

@stuartleeks Addressed in 337124e36a9a80d6522e862c3454a56f8893a29c

SauravMaheshkar commented 1 year ago

Gentle ping @stuartleeks @chrmarti

jkeech commented 1 year ago

/test

github-actions[bot] commented 1 year ago

:robot: pr-bot :robot:

:warning: When using /test on external PRs, the SHA of the checked commit must be specified

(in response to this comment from @jkeech)

jkeech commented 1 year ago

/test-force-approve

CODEOWNERS update only

github-actions[bot] commented 1 year ago

:robot: pr-bot :robot:

:white_check_mark: Marking tests as complete (for commit 337124e36a9a80d6522e862c3454a56f8893a29c)

(in response to this comment from @jkeech)