search

devcontainers / cli

A reference implementation for the specification that can create and configure a dev container from a devcontainer.json.
https://containers.dev
MIT License
1.52k stars 215 forks source link

Question - Publishing OCI Artifacts - Should the layer be compressed? #664

Open CodeMan99 opened 12 months ago

CodeMan99 commented 12 months ago

I am currently building a new supporting tool and just wondering if this is correct.

$ oras pull ghcr.io/devcontainers/features/git:latest
Downloading ebd18821c6cc devcontainer-feature-git.tgz
Downloaded  ebd18821c6cc devcontainer-feature-git.tgz
Pulled [registry] ghcr.io/devcontainers/features/git:latest
Digest: sha256:f839be8a0203abe12c917b262b1a1330b8286f9576ef21ea4a26ed60c5bc9947
$ file devcontainer-feature-git.tgz 
devcontainer-feature-git.tgz: POSIX tar archive

Inspecting the layer manually reveals that the media type is application/vnd.devcontainers.layer.v1+tar. However, the filename from the org.opencontainers.image.title annotation gives a ".tgz" extension. The actual file does not seem to be compressed.

I'm just wondering which is actually correct? A bare tar archive? Or a gzip'd compressed version?

samruddhikhandale commented 11 months ago

Hi 👋

That's an interesting find, thanks for raising this question. Looping in @joshspicer