devcontainers / cli

A reference implementation for the specification that can create and configure a dev container from a devcontainer.json.
https://containers.dev
MIT License
1.57k stars 220 forks source link

Variable substitution does not allow default values containing a colon #883

Open grthr opened 2 months ago

grthr commented 2 months ago

The current implementation does not support default values in localEnv or containerEnv substitution that include a colon.

Example:

 "WEBSITE_URL": "${localEnv:WEBSITE_URL:https://example.com"

Current behavior: If $WEBSITE_URL is not present, the variable is just set to https

Expected behavior: If $WEBSITE_URL is not present, the variable should be set to https://example.com

grthr commented 2 months ago

PR #882