search

devcontainers / feature-starter

A bootstrap repo for self-authoring Dev Container Features
https://containers.dev
MIT License
277 stars 132 forks source link

Simplify sample scripts #5

Closed chrmarti closed 2 years ago

chrmarti commented 2 years ago

@joshspicer Simplified the scripts a bit. Also changed them to use /bin/sh which is available in more images (e.g., Alpine). Not sure if we should add Alpine to the CI tests.

joshspicer commented 2 years ago

nice!

joshspicer commented 2 years ago

It would be great to add alpine here.

I think I have an assumption in the test command that all scripts will be executed against /bin/bash. I've added an action item to https://github.com/devcontainers/cli/issues/139 to fix that. After that, we should add alpine:latest to the set of images in the test

@chrmarti