[node] nvm_install_snippet 'source' should probably be '.'

devcontainers / features

A collection of Dev Container Features managed by Dev Container spec maintainers. See https://github.com/devcontainers/feature-starter to publish your own

https://containers.dev/features

MIT License

920 stars 371 forks source link

[node] nvm_install_snippet 'source' should probably be '.' #565

Open brcarp opened 1 year ago

brcarp commented 1 year ago

This line below, produces a sh: 6: source: not found error in /bin/sh, in contrast to the . commands in nvm_rc_snippet which work in /bin/sh as well as /bin/bash:

https://github.com/devcontainers/features/blob/852f1f0567280b465913b487d5f8c773122c36ab/src/node/install.sh#L122

There's a discussion around this error in #440.

samruddhikhandale commented 1 year ago

Hi 👋

Thanks for reporting the issue, @brcarp would you be interested in opening a PR to fix this bug? We appreciate community contributions.