search

devcontainers / features

A collection of Dev Container Features managed by Dev Container spec maintainers. See https://github.com/devcontainers/feature-starter to publish your own
https://containers.dev/features
MIT License
810 stars 312 forks source link

Revert archived common-alpine feature #951

Open GrunkaBunka opened 2 months ago

GrunkaBunka commented 2 months ago

Currently the feature stored at src/common-utils is apaired down version of the older common-alpine feature.

Previously having a common-alpine as an available feature was a great help for those seeking a linux dev-container sensible settings.

With this being said, there are aspects of the dev-container feature that were very useful, and have since been removed/missing. Support for additional supplementary groups and specifying additional packages are vital to development.

samruddhikhandale commented 2 months ago

Hi 👋

When we migrated over the common-utils Feature, we ensured to keep the installations and Feature options intact.

Support for additional supplementary groups

From https://github.com/devcontainers/features/tree/main/src/common-utils#options, the Feature has options to setup user groups. Kindly see username, userUid and userGid for reference.

specifying additional packages are vital to development.

Unfortunately, I don't see how we were adding additional packages to common-alpine.sh. Can you help me understand this point? thanks!

Let me know if you have any other questions, thanks!