Closed Roemer closed 10 months ago
So I should create a proposal markdown file similar to https://github.com/devcontainers/spec/pull/196? Or what did you mean with CLI changes? Can do. That should be in its own PR I suppose.
As this was discussed in https://github.com/devcontainers/spec/discussions/301 and has decent amount of upvotes, I believe it should be alright not creating a spec issue (or maybe create one and link it to the discussion)
So I should create a proposal markdown file similar to https://github.com/devcontainers/spec/pull/196?
Said that, it would be great if you can create a similar PR, if the proposal looks good then we can start thinking about the CLI code changes.
// cc @bamurtaugh Feel free to correct my understanding, if needed.
I created a simple proposal for the spec change: https://github.com/devcontainers/spec/pull/328
@samruddhikhandale any update on this?
Updating the property name as agreed on in https://github.com/devcontainers/spec/pull/328.
As in discussion https://github.com/devcontainers/spec/discussions/301, I would like to propose a way to add cli arguments to a
build
command, similar howrunArgs
add cli arguments to therun
command. This is needed for example for overriding the network eg.network=host
or for adding additional hosts. There is also a discussion about it over at vscode-remote: https://github.com/microsoft/vscode-remote-release/issues/3545Unfortunately,
build.args
is already used for DockerARG
uments so we need to use something else. I am open for naming proposals.Things I thought about are: