Syntax error in devcontainer feature JSON schema

jpillor-macquarie commented 11 months ago

        "dependsOn": {
          "description": "An object of Feature dependencies that must be satisified before this Feature is installed. Elements follow the same semantics of the features object in devcontainer.json",
          "additionalProperties": true
          "type": "object"
        },

missing a comma here https://github.com/devcontainers/spec/blob/main/schemas/devContainerFeature.schema.json#L60

@joshspicer

eljog commented 11 months ago

Thank you for reporting. I have a PR out to fix this

jpillor-macquarie commented 11 months ago

Thanks!🙏

Get Outlook for iOShttps://aka.ms/o0ukef

From: Eljo George @.> Sent: Saturday, December 23, 2023 10:51:35 AM To: devcontainers/spec @.> Cc: Jaime Pillora @.>; Author @.> Subject: Re: [devcontainers/spec] Syntax error in devcontainer feature JSON schema (Issue #356)

External Communication

Closed #356https://github.com/devcontainers/spec/issues/356 as completed via #357https://github.com/devcontainers/spec/pull/357.

— Reply to this email directly, view it on GitHubhttps://github.com/devcontainers/spec/issues/356#event-11329869687, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BA4STLV6ECSVRLFDWWJ7Y6DYKYMIPAVCNFSM6AAAAABA7H7VW2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGMZDSOBWHE3DQNY. You are receiving this because you authored the thread.Message ID: @.***>

This email and any attachment is confidential. If you are not the intended recipient, please contact the sender and delete this message. Macquarie does not represent or warrant that this communication is free from computer viruses or other defects. For important disclosures and information about the incorporation and regulated status of Macquarie Group entities please see: www.macquarie.com/disclosures

devcontainers / spec

Syntax error in devcontainer feature JSON schema #356