search

devcontainers / templates

Repository for Dev Container Templates that are managed by Dev Container spec maintainers. See https://github.com/devcontainers/template-starter to create your own!
https://containers.dev/templates
MIT License
924 stars 242 forks source link

Improvment - Add .NET global tools to path #138

Closed cmaneu closed 1 year ago

cmaneu commented 1 year ago

Fixes #137

cmaneu commented 1 year ago

Hi @samruddhikhandale, Great suggestion :) I just have a question: where is the current username set? I don't see it in the Docker file or in the devcontainer.json.

samruddhikhandale commented 1 year ago

where is the current username set? I don't see it in the Docker file or in the devcontainer.json.

@cmaneu I'm not sure if you are asking this question for the image or template.

Image - The common-utils Feature sets the username - https://github.com/devcontainers/images/blob/main/src/dotnet/.devcontainer/devcontainer.json#L9

Template - The CLI automatically configures from the metadata of the image - https://containers.dev/implementors/spec/#metadata

cmaneu commented 1 year ago

Thanks @samruddhikhandale Closing this PR, Superseed by https://github.com/devcontainers/images/pull/495