search

devcontainers / templates

Repository for Dev Container Templates that are managed by Dev Container spec maintainers. See https://github.com/devcontainers/template-starter to create your own!
https://containers.dev/templates
MIT License
990 stars 254 forks source link

Indicate Dockerfile can be used, simplify now that image metadata is available #90

Closed Chuxel closed 1 year ago

Chuxel commented 1 year ago

This PR addresses several things in existing templates to dramatically simplify and clarify them.

  1. It adds in a reference to a to-be-written guide that explains how image vs Dockerfile vs Docker Compose usage when just an image is referenced.

  2. It removes Features and settings where they are now in the actual referenced image's metadata. This capability is new, so not all templates have been updated.

    1. It also removes the common script being in the docker and kubernetes templates since any reference to a custom image has been removed.
    2. It also removes the java-8 template since it is no longer needed given the difference was pure VS Code settings, which are now on the image.

  3. It removes a couple of "mount" references that points to docker-from-docker given the Feature can now handle this automatically.

  4. It takes advantage of the _REMOTE_USER environment variable in the Kubernetes templates now that this is available (and was not when it was created).

  5. It drops .NET 3.1 from lists given it is now out of support.

  6. It fixes comments in the "existing Dockerfile" and "existing Docker Compose" scenarios that incorrectly mentioned un-commenting to access root. Given these are customer images, there's no garuntee image metadata for remoteUser is present.

Chuxel commented 1 year ago

The java-8 test failed because this removed java-8. :)

Chuxel commented 1 year ago

@samruddhikhandale Updated!