search

devcshort / react-hls

Simple React component for playing hls/rtmp live streams.
https://www.npmjs.com/package/react-hls-player
MIT License
118 stars 48 forks source link

Support react 17 as peerDependency #37

Open clumsyjedi opened 2 years ago

clumsyjedi commented 2 years ago

As per https://github.com/devcshort/react-hls/issues/34 peerDependency errors are emitted when using this module with react 17. This change should suppress these errors, we have tested it using a sample video.

Users are welcome to use a deployed artifact of @panelist/react-hls-player until this is merged / #34 is resolved.

soheil commented 2 years ago

I don't think this is really a fix, you're just removing the dependency check instead of actually refactoring whatever code that relies on React 16. I'm having issues with playerRef when forcing it to use React 17.