search

devcshort / react-hls

Simple React component for playing hls/rtmp live streams.
https://www.npmjs.com/package/react-hls-player
MIT License
118 stars 48 forks source link

Convert package to TypeScript #5

Closed devcshort closed 3 years ago

devcshort commented 3 years ago

Currently I have an index.d.ts file so that users of my package can take advantage of VSCode's intellisense. While this works, I'd prefer to have this package changed to use proper types, interfaces, etc and utilize TypeScript for the components within the src directory.

This change will need to take semver in to consideration, and changes will need to be fully backwards compatible with the current API. Once this change is done, I should only need to update a minor version for the next publish.

mxrcochxvez commented 3 years ago

Can I tackle this?

devcshort commented 3 years ago

@mxrcochxvez for sure!

devcshort commented 3 years ago

@all-contributors please add @mxrcochxvez for changing the code to typescript and being awesome!

allcontributors[bot] commented 3 years ago

@devcshort

I've put up a pull request to add @mxrcochxvez! :tada:

osmarpetry commented 3 years ago

I already did it o. My work project, very easy today with babel to have js and ts code. I will check this out tonight