devdaydresden / devday_website

The website code for https://www.devday.de/
BSD 3-Clause "New" or "Revised" License
8 stars 9 forks source link

Change Favourite Behaviour to Use PUT/DELETE #277

Closed jenslauterbach closed 2 years ago

jenslauterbach commented 2 years ago

Minor change as proposed by Jan to not have separate endpoints to favourite/unfavourite sessions, but to use PUT/DELETE on the same endpoint.

Now the output of /api/sessions/ and /api/sessions/<session-name>/ looks like this:

[
    {
        "id": "acheing-a-internally-attached-limit",
        "url": "http://localhost:8000/api/sessions/acheing-a-internally-attached-limit/",
        "title": "Acheing A Internally Attached Limit",
        "description": "Dolor quisquam modi magnam sit sed. Modi velit neque dolor. Voluptatem consectetur dolorem ipsum amet quaerat adipisci. Ut quiquia numquam adipisci. Modi tempora quisquam quiquia.",
        "speakers": [
            {
                "url": "http://localhost:8000/api/speakers/jana-vogel/",
                "name": "Jana Vogel",
                "image": ""
            }
        ],
        "event": "devdata.18",
        "actions": {
            "favourite": "http://localhost:8000/api/sessions/acheing-a-internally-attached-limit/favourite"
        }
    }
]

Run PUT http://localhost:8000/api/sessions/acheing-a-internally-attached-limit/favourite to favourite a session and DELETE http://localhost:8000/api/sessions/acheing-a-internally-attached-limit/favourite to unfavourite it.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1505481088


Files with Coverage Reduction New Missed Lines %
talk/api_views.py 3 63.46%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 1502732878: 0.04%
Covered Lines: 3805
Relevant Lines: 3841

💛 - Coveralls