search

devdisplay / DevDisplay

DevDisplay is a global open source community platform that brings together all your tech needs in one place. 🌟 Join DevDisplay to Showcase your skills, connect globally, collaborate, build and promote.
https://www.devdisplay.org
MIT License
146 stars 290 forks source link

Add : sidgureja7803 - Added Voice Search and Skills Dropdown Functionality #386

Open sidgureja7803 opened 1 month ago

sidgureja7803 commented 1 month ago

Description

Currently, users can only search for people and select skills by manually typing in the search bar and skill selection field. This can be time-consuming and may not provide the best user experience.

Related Issues

1- There is no voice search functionality, requiring users to type out search queries manually. 2 - The skills field requires users to manually input their skills, which can be cumbersome.

Changes Proposed

1 - Voice Search: Add a feature that allows users to search for people using voice input instead of typing. 2 - Skills Dropdown: Add a dropdown menu to the skills selection field, allowing users to select from a list of predefined skills without needing to type.

Checklist

Screenshots

Screenshot 2024-10-23 014430 Screenshot 2024-10-23 014443

Note to reviewers

Please review and approve this PR ASAP as it might cause conflicts after users are added, in the ProfileList.json file.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devdisplay ❌ Failed (Inspect) Oct 25, 2024 9:56am
netlify[bot] commented 1 month ago

Deploy Preview for devdisplay failed.

Name Link
Latest commit bac1e8dcccc1abde45a2ba0706801130b2e08a91
Latest deploy log https://app.netlify.com/sites/devdisplay/deploys/671b6b10aacb8400087a86ec
sidgureja7803 commented 1 month ago

@ishap11 , Please review this PR and kindly merge it. And please tell, why the checks are failing ??

ishap11 commented 1 month ago

Hi @sidgureja7803 , could you please let me know the issue number where the voice search and skills dropdown task is assigned?

The checks are failing due to a syntax issue in the ProfileList.json file. This often happens when multiple people add their names to the file at the same time. If two contributors make changes without proper coordination, it can lead to issues like missing commas or incorrect JSON structure, which causes the checks to fail.

The failing checks are related to Netlify’s deployment process, which seems to be a configuration issue rather than something caused by your code. The Vercel deployment passed successfully, so it's likely a project setup or admin-related issue with Netlify.

I'll notify the admin to check the Netlify settings and resolve the deployment failure. You're good on your end!

Thanks!

sidgureja7803 commented 1 month ago

Hi @sidgureja7803 , could you please let me know the issue number where the voice search and skills dropdown task is assigned?

The checks are failing due to a syntax issue in the Profile-List.json file. This often happens when multiple people add their names to the file at the same time. If two contributors make changes without proper coordination, it can lead to issues like missing commas or incorrect JSON structure, which causes the checks to fail.

The failing checks are related to Netlify’s deployment process, which seems to be a configuration issue rather than something caused by your code. The Vercel deployment passed successfully, so it's likely a project setup or admin-related issue with Netlify.

I'll notify the admin to check the Netlify settings and resolve the deployment failure. You're good on your end!

Thanks!

These checks are failing because when I created this PR, after that many people registered their name in the ProfilesList.json file. So it is creating conflicts.

ishap11 commented 1 month ago

@sidgureja7803 , could you please let me know the issue number where the voice search and skills dropdown task is assigned?

sidgureja7803 commented 1 month ago

@sidgureja7803 , could you please let me know the issue number where the voice search and skills dropdown task is assigned?

issue - 369, created by R Advani, I had a word with him, and he is not working on it. so i started working on it and thus, i thought of adding voice search functionality as well.

sidgureja7803 commented 1 month ago

@sidgureja7803 , could you please let me know the issue number where the voice search and skills dropdown task is assigned?

@ishap11 Please reply ASAP, whether you will be merging this PR or not ?? because, today is 23rd Oct and Hacktober-fest takes 7 days to validate the merged PR. So that i can work on other issues

ishap11 commented 1 month ago

@sidgureja7803, moving forward, please ensure that before contributing, you first raise an issue. If the issue is assigned to you, you can then proceed. Otherwise, if you find an existing issue, kindly comment there indicating that you want to work on it or suggest additional functionalities related to the issue. @codeaashu, kindly review his work.

sidgureja7803 commented 1 month ago

@ishap11 @codeaashu any update ??

codeaashu commented 1 month ago

hello @sidgureja7803, thanks for your interest in contributing to DevDisplay!

Add "Voice Search" Functionality only not skills Dropdown it's

Resolve the code then raise the PR with 1 - Add your Profile 2 - Voice Search Functionality

and one more things

We noticed you forgot to star the #DevDisplay Repo. It's like making an amazing sandwich and forgetting to take a bite! -- I think our repo's feeling a little lonely without your 🤗 So, be sure to star the DevDisplay GitHub Repository. 🌟

💌 This is a mandatory step for all contributors. & It's is the first priority of contribution in DevDisplay 💌

Thanks 👍🏻

sidgureja7803 commented 1 month ago

hello @sidgureja7803, thanks for your interest in contributing to DevDisplay!

Add "Voice Search" Functionality only not skills Dropdown it's

Resolve the code then raise the PR with 1 - Add your Profile 2 - Voice Search Functionality

and one more things

We noticed you forgot to star the #DevDisplay Repo. It's like making an amazing sandwich and forgetting to take a bite! -- I think our repo's feeling a little lonely without your 🤗 So, be sure to star the DevDisplay GitHub Repository. 🌟

💌 This is a mandatory step for all contributors. & It's is the first priority of contribution in DevDisplay 💌

Thanks 👍🏻

@codeaashu I have removed the skills dropdown feature Only going forward with the voice feature. I have made the changes in the code of this PR, and kindly merge it, otherwise it will create conflicts with the base branch. Going head with this PR instead of creating a new one, will be a good practice as per me.

codeaashu commented 1 month ago

download

Error in code it's failed in deployment also not seen a preview so I an watch live it Not ready for deployment

check out this

sidgureja7803 commented 1 month ago

download

Error in code it's failed in deployment also not seen a preview so I an watch live it Not ready for deployment

check out this @codeaashu, Sir, this is happening just because the merge of the PR was delayed by your side. As you asked to remove the search bar feature, i removed it. But meanwhile, Some people made changes in the HomePage.jsx file and Search.jsx file and due to this conflicts were created. Now again, I have made changes in the code and resolved the conflicts. Check again, if it working or not for deployment.