search

devdotxyz / eth-xyz

A wildcard metadata profile for .eth names.
https://eth.xyz
GNU Lesser General Public License v3.0
64 stars 9 forks source link

Emoji, unicode, non-ASCII .eth names #22

Open jhxyz opened 2 years ago

jhxyz commented 2 years ago

Emoji, unicode, non-ASCII .eth names result in a 404 page.

ENS is still in discussion on this subject. The outcome of that discussion will inform technical updates to Ethers.js, which is what would power emoji and other special character support on Eth.xyz.

https://github.com/ethers-io/ethers.js/issues/42#issuecomment-1124691542 https://discuss.ens.domains/t/ens-name-normalization/8652/19

jhxyz commented 2 years ago

@brendandebeasi note from https://twitter.com/adraffy/status/1473128565453385732?s=21 image

brendandebeasi commented 2 years ago

This is related to the underlying ethers.js library we use to resolve ENS names. https://github.com/ethers-io/ethers.js/issues/42

The maintainer has stated that they may not want to support the full UTF-8 character set due to the possibility of homoglyph attacks. That said, ENS themselves support the full UTF-8 character set, so I would think it makes sense for ethers.js to support this as well.

jhxyz commented 2 years ago

Pending Ethers.js update ethers-io/ethers.js#42

genxyzteam commented 2 years ago

This user has a Chinese prefix in his eth.xyz profile name

sangenghumeng1

https://twitter.com/sangenghumeng1/status/1478066023345451008?s=20

genxyzteam commented 2 years ago

https://twitter.com/lookinforgangas/status/1502658571829497856 The Guy @lookinforgangas Replying to @xyz @ensdomains What about emoji domains? 😆😅😂.eth for example?

jhxyz commented 2 years ago

Example names affected, for tracking:

image