devedmonton / DES-Website

The Dev Edmonton Society website! We empower Edmonton Developers!
https://devedmonton.com
MIT License
28 stars 74 forks source link

fix bug with not closing mob nav menu #187

Closed olimpiuus closed 1 year ago

olimpiuus commented 1 year ago

What issue is this referencing?

this pr fixes #186 "When I click on an item in the menu, the menu doesn't collapse #186"

Have you run the linting command in the README.md?

Have you taken a look at our contributing guidelines?

My node version matches the one suggested when running nvm use?

olimpiuus commented 1 year ago

ugly but working. By the way this one is easiest path.

MandyMeindersma commented 1 year ago

Okay so two things:

first, something looks very off in the preview: image

The other thing is that I am realizing that this was working with the <a> tags, I mean I agree that the whole thing that we should follow the SPA standards but it is a pretty light fast site. The extra reload wouldn't matter if we are running into so many other issues.

Thoughts?

olimpiuus commented 1 year ago

For now tag a will not route us anywhere, its just hadler of click event for menu closing. We can change it for div, will be no difference. Better leave nuxt -links with divs or inside it to handle logic. Anyway there is stupid that nuxt link cant hold "click" logick.

About styling, it looks weird. I coudnt find problem, on my mac it works fine. Is it Windows or Android?

Screenshot 2023-08-03 at 10 41 38 PM
olimpiuus commented 1 year ago

above i added funcionality to close mobile menu by click outside menu itself. same file , related bug.

MandyMeindersma commented 1 year ago

image

So you see in the build instructions? click "details" and it will bring you to this pr as a build. Thats where you should see the weird styling.

Cause it looks like it still happens On the netlify build

olimpiuus commented 1 year ago

tag a just makes mess inside nuxt link. so i wrap it by li