Closed olimpiuus closed 1 year ago
ugly but working. By the way this one is easiest path.
Okay so two things:
first, something looks very off in the preview:
The other thing is that I am realizing that this was working with the <a>
tags, I mean I agree that the whole thing that we should follow the SPA standards but it is a pretty light fast site. The extra reload wouldn't matter if we are running into so many other issues.
Thoughts?
For now tag a will not route us anywhere, its just hadler of click event for menu closing. We can change it for div, will be no difference. Better leave nuxt -links with divs or inside it to handle logic. Anyway there is stupid that nuxt link cant hold "click" logick.
About styling, it looks weird. I coudnt find problem, on my mac it works fine. Is it Windows or Android?
above i added funcionality to close mobile menu by click outside menu itself. same file , related bug.
So you see in the build instructions? click "details" and it will bring you to this pr as a build. Thats where you should see the weird styling.
Cause it looks like it still happens On the netlify build
tag a just makes mess inside nuxt link. so i wrap it by li
What issue is this referencing?
this pr fixes #186 "When I click on an item in the menu, the menu doesn't collapse #186"
Have you run the linting command in the
README.md
?npm run lint-check
Have you taken a look at our contributing guidelines?
My node version matches the one suggested when running
nvm use
?