devedmonton / DES-Website

The Dev Edmonton Society website! We empower Edmonton Developers!
https://devedmonton.com
MIT License
26 stars 66 forks source link

Updates the default layout and TheFooter so that footer color will be… #203

Closed deejayjay closed 1 year ago

deejayjay commented 1 year ago

Completes #193

deejayjay commented 1 year ago

@MandyMeindersma: I have changed the code so that footer will have the "special" theme in All Events page and All Resources page. I personally don't like the idea of having a different theme for footer only for 2 pages in the website. Please check and confirm that you are fine with what is in the PR.

MandyMeindersma commented 1 year ago

Oh shoot, I should have been more clear in the issue. I think you are right, changing the footer based on the page seems weird. I thinking making it blue accross all pages is the way to go

MandyMeindersma commented 1 year ago

The footer looks great on the community events and resources page though

deejayjay commented 1 year ago

Oh shoot, I should have been more clear in the issue. I think you are right, changing the footer based on the page seems weird. I thinking making it blue accross all pages is the way to go

@MandyMeindersma: Alright. I will revert the code that makes footer theme dynamic, and make the footer light blue all across the app later in the evening. Thanks

MandyMeindersma commented 1 year ago

Sorry! Thank you!

deejayjay commented 1 year ago

Sorry! Thank you!

No worries. That was a quick fix, and I also learned something while implementing it :). Ready for another review now.