devedmonton / DES-Website

The Dev Edmonton Society website! We empower Edmonton Developers!
https://devedmonton.com
MIT License
28 stars 74 forks source link

Create and redirect bylaws page #268

Closed CaioCintra closed 1 year ago

CaioCintra commented 1 year ago

I created the bylaws file according to the docs linked on the footer and changed redirects

What issue is this referencing?

Fixes issue #136

Does the following command run without warnings or errors?

Have you taken a look at our contributing guidelines?

My node version matches the one suggested when running nvm use?

MandyMeindersma commented 1 year ago

I was so wrong, Okay let me look into this, idk why the build isn't seeing the redirects

MandyMeindersma commented 1 year ago

Okay I changed a setting that might fix it, rebuilding now

MandyMeindersma commented 1 year ago

okay so the build is being weird.

This old builds before I pointed to the right folder: image

Now they at least see the redircts: image

But yours isn;t listed and I am not sure why

MandyMeindersma commented 1 year ago

oh ha. It's cause we have two redirect files.....

Can you delete the one inside the root of the repo and then add your changes to the one inside /public

https://github.com/devedmonton/DES-Website/blob/main/public/_redirects

CaioCintra commented 1 year ago

Ok haha, now it makes more sense

MandyMeindersma commented 1 year ago

Excuse me build, it is literally right there:

image

image

CaioCintra commented 1 year ago

The other one works and is the same thing, why it's not working??

MandyMeindersma commented 1 year ago

hmmmm and on your local if you do localhost:3000/bylaws it works right?

CaioCintra commented 1 year ago

In my localhost both does not work actually

MandyMeindersma commented 1 year ago

what commands are you running? to build?

CaioCintra commented 1 year ago

npm run build

MandyMeindersma commented 1 year ago

what happens when you run npm build generate

CaioCintra commented 1 year ago

Doesn't work, then suggests the npm run build command

MandyMeindersma commented 1 year ago

or maybe npm run start or npx serve

These people seem to be having simiilar issue: https://answers.netlify.com/t/page-not-found-only-when-visiting-directly-with-the-url/94491/16

CaioCintra commented 1 year ago

npm run start may work but it says i'm already using port 3000 but I closed everything, I will check that and see if runs normally

CaioCintra commented 1 year ago

Ok, now it's working but not the redirects

MandyMeindersma commented 1 year ago

hahaha omg @DerrykBoyd I think I need help.

I fixed it so that netlify does see the redirects and it does list them but it still thinks the page is missing, and I have googled everything I can think of. Any ideas?

DerrykBoyd commented 1 year ago

hahaha omg @DerrykBoyd I think I need help.

I fixed it so that netlify does see the redirects and it does list them but it still thinks the page is missing, and I have googled everything I can think of. Any ideas?

I'm not sure why it's trying to prerender bylaws. Doesn't do that when I run generate locally. Anyhow... try adding this to the nuxt config, then hopefully it won't prerender that route and build will pass?

    // nitro settings
    nitro: {
        prerender: {
            ignore: ["/bylaws"],
        },
    },
MandyMeindersma commented 1 year ago

That works!! 🥳 🥳 🥳 🎉 🎉 🎉

Thank you @DerrykBoyd

@CaioCintra add that to this pr and then you should be good!

MandyMeindersma commented 1 year ago

Oh perfect! Thank you @CaioCintra for working through this!