Added Changes From Discussion

[kodyVS]

What issue is this referencing?

No issue reference but adding changes from the discussion

Do these code changes work locally and have you tested that they fix the issue yourself?

• [x] yes!

Does the following command run without warnings or errors?

• [x] yes! npm run pr-checks

Have you taken a look at our contributing guidelines?

• [x] yes!

My node version matches the one suggested when running nvm use?

• [x] yes!

[MandyMeindersma]

Did you want events and resources in both menu's?

[DerrykBoyd]

I'm out of the loop for the discussions referenced, but this looks good to me 👍

[MandyMeindersma]

@kodyVS sorry I gave you merge conflicts, once we figure out what actually goes into the menu then this looks good from me too

[kodyVS]

No problem.

The navigation in the home sub menu goes to the sub-headers on the main page and the main links go to the full pages.

We could rename the home sub menu sections to get rid of any confusion instead of "Meetups, events and resources" we have "Community" and add "Newsletter" to the list.

[MandyMeindersma]

Ooooohhhh woops, my bad, you are right. Yeah this looks good to me!

[MandyMeindersma]

Oh one more question, is there a reason you deleted all the unit tests? I think they are still valid ones?

[kodyVS]

I deleted the unit tests because I changed the way the menu is displayed to utilize the built-in features of vue and tailwind and in doing so, changed the methods that were in the test. However, I can add 2 more unit tests for the methods I replaced.

[MandyMeindersma]

Thank you so much for adding those! I appreciate it!

Sorry my changes are now breaking your imports :)

[MandyMeindersma]

@all-contributors add @kodyVS for code and ideas

[allcontributors[bot]]

@MandyMeindersma

I've put up a pull request to add @kodyVS! :tada:

[MandyMeindersma]

Thank you so much Kody!