search

devedmonton / DES-Website

The Dev Edmonton Society website! We empower Edmonton Developers!
https://devedmonton.com
MIT License
22 stars 52 forks source link

Hover state for button is not ideal #275

Closed MandyMeindersma closed 10 months ago

MandyMeindersma commented 10 months ago

It just disappears on hover state

image

and then on hover:

image

LalitDeore commented 10 months ago

Hey @MandyMeindersma i can work on this issue could you please assign this task to me so i can work on this issue?

LalitDeore commented 10 months ago

Hey @MandyMeindersma I am not familiar with Vue. Could please tell me in which file is the all tailwind css of about our slack button i found this button ` <VButton appearance="inverted"

About Our Slack</VButton

` here i can not see any tailwind css. so not able where to updated the css. that's why please tell me where is the c css of about our slack button

MandyMeindersma commented 10 months ago

Hey @LalitDeore so the beauty of tailwind is that their is no css. You add classes onto the HTML tags and they write the css for you

So lets take margin for example: https://tailwindcss.com/docs/margin#add-margin-to-a-single-side

I can add class="mt-6" which will add margin to the top of whatever HTML tag I am adding it too.

Let me know if that helps or if you need another hint to get started :)

SeaBebop commented 10 months ago

Made an attempt on this in https://github.com/devedmonton/DES-Website/pull/279

MandyMeindersma commented 10 months ago

@SeaBebop You have the correct approach but this issue is assigned to @LalitDeore and as they are in the middle of making changes to their pr and I would like to give them a chance to learn. We have many other issues that are open :)

I'll close your pr for now and reopen after @LalitDeore has had a chance