devedmonton / DES-Website

The Dev Edmonton Society website! We empower Edmonton Developers!
https://devedmonton.com
MIT License
22 stars 52 forks source link

Making the error page work on 404 #276

Closed MandyMeindersma closed 10 months ago

MandyMeindersma commented 10 months ago

What issue is this referencing?

271

Do these code changes work locally and have you tested that they fix the issue yourself?

Does the following command run without warnings or errors?

Have you taken a look at our contributing guidelines?

My node version matches the one suggested when running nvm use?

MandyMeindersma commented 10 months ago

So the redirect file didn't actually work but vue has a thing with the error page where it will just serve that. But the error.vue file has to be in the root (meaning that I had to add the footer and menu manually rather than it just getting added automagically as a page)

Not sure if this has bad code smell in vue