Closed LalitDeore closed 10 months ago
Okay so a couple things!
netlify/dev-edmonton/deploy-preview
then you will see that it failed because of linting things. It tell you to run prettier.
Finally:
You changed VButton to be a regular button, that isn't ideal because that isn't what the issue was asking, we only want to change the hover state. So when you are approaching this problem first I would try to investigate anything that you don't know what it is. VButton
is actually a component that we made. If you look around the code there are actually a couple instances of it: https://github.com/search?q=repo%3Adevedmonton%2FDES-Website%20vbutton&type=code Your changes only fix VButton in one spot, we want to make sure they are fixed in all the spots. Whats the best way to do that?
Hey @MandyMeindersma First of all, thank you so much for having a detailed explanation of the problem in my PR.
Hover Button:
Yay for being new to open source! Glad you made a pr! So exciting!
just a couple more changes and then we should be good to merge!
As for the commands you have to run, you didn't break anything this build so you don't have to run them but it's good to know what all of the commands in the readme do. I was talking about these ones:
# run the linter
$ npm run lint-check # check for linting errors
$ npm run lint-fix # fix linting errors
# run the formatter
$ npm run format-check # check for formatting errors
$ npm run format # fix formatting errors
Oh also one more thing. When you click the "Details" button now you can see a test website with your changes. When I hover I don't see the border you added. I think adding more hover:
like I suggested should fix that
Oh the joys of dealing with merge conflicts now too! You really are getting the full experience of open source. Let me know if you need any help with the merge conflicts
Yes, It will be helpful if you tell me how I can solve the merge conflict issue.
Try doing some googling or following this tutorial https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line
If you still have questions after that let me know :)
dealing with merge conflicts
Is this issue resolved? I have solved the merge conflict with the main branch. Please checkout once.
Almost! We are so close!
You just have one other suggestion left from me. If you go to the "files changed" tab it should show. I just need one more hover:
Added one more hover
Looks Great!
@all-contributors add @LalitDeore for code
@MandyMeindersma
I've put up a pull request to add @LalitDeore! :tada:
Issue detail. After hovering to the "about our slack" button, it was disappearing. and i change the VButton component to the normal button and add own tailwind css to it.
Normal Button
Hover Button