search

devedmonton / DES-Website

The Dev Edmonton Society website! We empower Edmonton Developers!
https://devedmonton.com
MIT License
28 stars 74 forks source link

Fixes Issue #278 Adding to list of meetups #283

Closed scratch-passive closed 10 months ago

scratch-passive commented 11 months ago

Issue #278

This PR fixes issue #278

Do these code changes work locally and have you tested that they fix the issue yourself?

Does the following command run without warnings or errors?

Have you taken a look at our contributing guidelines?

My node version matches the one suggested when running nvm use?

MandyMeindersma commented 11 months ago

You can take a look at why the build failed. It's some linting and formatting things. Look at the readme for the commands to fix

MandyMeindersma commented 11 months ago

Oh sorry! I am being confusing.

ImageKit is what we use to host our images. That way we have less images and files on the site and our site loads faster!

So Nuxt does this cool interaction with imagekit. Where you just pass the path into the image source and then it knows to go to imagekit rather than trying to load the local image. These are all the images of the meetups that we are hosting on imagkit: image

So with exchangeJS there's is like this: https://github.com/devedmonton/DES-Website/blob/main/components/section/Meetups.vue#L50

It just follows the same folder path that imagekit uses without uploading a photo to our repo.

Does that all make sense? :)

Thanks for taking all the effort to make these changes :)

MandyMeindersma commented 11 months ago

@scratch-passive little ping to remind you! Would love to have these changes in :)

MandyMeindersma commented 10 months ago

closing due to inactivity