Closed leslietech closed 7 months ago
Thanks for the review. The image is now at /img/logos/meetups/DataScience.png.
Ah okay, so we are still on different wavelengths :P Let me try another example.
So the YEG Women in Tech logo (YEGWIT) is not saved to the repo. It is saved to our cloud storage with Image kit here: https://ik.imagekit.io/des/meetups/yegwit.png?updatedAt=1694047415152
So nuxt (our vue framework) knows that we use image kit and it knows that any time we throw a logoSvg
or a logoImg
that it will look for that path on our cloud image kit.
So if you look at the way yegwit does it, yours should be similar. https://github.com/devedmonton/DES-Website/blob/f79a99a637ecaadefdac1bf85112b8ede055f880/store/meetups.js#L56-L59
Because the url pattern for the yeg image: https://ik.imagekit.io/des/meetups/yegwit.png?updatedAt=1694047415152 has the same folder structure as the data science image: https://ik.imagekit.io/des/meetups/DataScience_Nvpcx6-aY?updatedAt=1705546844312
If I am being confusing we can jump on a call or chat in slack too, whatever works cause this imagekit stuff is a little magic behind the scenes :)
Ahh, got it. I would have not gotten the ImageKit relation with the website, had it not been for your last response. The image is at https://ik.imagekit.io/des/meetups/DataScience_Nvpcx6-aY. Works in my dev setup. Another PR update on the way...lol.
I think that the image is called "DataScience_Nvpcx6-aY", so "/meetups/DataScience_Nvpcx6-aY" resolves it.
omg you are right I did name it horribly lol
I renamed it to a better name now: https://ik.imagekit.io/des/meetups/DataScience
So sorry to make you make another change. Thank you!
No worries. Am loving this. I am still learning JS, so it is fascinating how I am able to see how most of it works and how it connects. The CDN relative image URL reference was new to me too. Am pushing the update now.
perfect! Thank you
What issue is this referencing?
Fixes #278
Do these code changes work locally and have you tested that they fix the issue yourself?
Does the following command run without warnings or errors?
npm run pr-checks
Have you taken a look at our contributing guidelines?
My node version matches the one suggested when running
nvm use
?